Skip to content

Feat/custom data - #33

Merged
vinpogo merged 6 commits into
mainfrom
feat/custom-data
Feb 28, 2026
Merged

Feat/custom data#33
vinpogo merged 6 commits into
mainfrom
feat/custom-data

Conversation

@vinpogo

@vinpogo vinpogo commented Feb 28, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings February 28, 2026 09:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for attaching custom, user-typed metadata to Vueltip tooltip content and updates the directive value shape to align with the Content model.

Changes:

  • Introduce CustomVueltipData and Content.custom, and update directive binding type (Value) to support { text, custom?, placement? }.
  • Simplify directive parsing (toContent) and placement extraction for the new value shape.
  • Update Vueltip public exports, README usage examples, and demo usage to reflect the new API and show custom data.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
packages/vueltip/src/types.ts Adds CustomVueltipData, extends Content, and changes directive value typing to the new { text, custom?, placement? } shape.
packages/vueltip/src/index.ts Re-exports CustomVueltipData alongside Content.
packages/vueltip/src/directive.ts Updates directive binding types and converts bound values into Content via the new shape.
packages/vueltip/README.md Updates directive examples to use text and documents module augmentation for custom data.
demo/src/main.ts Demonstrates module augmentation for CustomVueltipData (currently in the runtime entry file).
demo/src/Tooltip.vue Displays the new content.custom field in the demo tooltip UI.
demo/src/App.vue Updates demo directive usages from content to text and adds a custom-data example.

Comment thread packages/vueltip/src/types.ts
Comment thread packages/vueltip/src/types.ts Outdated
Comment thread packages/vueltip/src/types.ts
Comment thread packages/vueltip/src/directive.ts
Comment thread packages/vueltip/src/directive.ts
Comment thread demo/src/main.ts
Comment thread demo/src/Tooltip.vue Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Comment thread packages/vueltip/src/options.ts
Comment thread packages/vueltip/README.md
@vinpogo
vinpogo merged commit f9f555d into main Feb 28, 2026
4 checks passed
@vinpogo
vinpogo deleted the feat/custom-data branch February 28, 2026 10:27
@github-actions github-actions Bot mentioned this pull request Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants